Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namadillo: fixing message appearing due to wrong string cast #1068

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Namadillo: fixing message appearing due to wrong string cast #1068

merged 1 commit into from
Sep 8, 2024

Conversation

pedrorezende
Copy link
Contributor

This PR fixes an error introduced in #1067 where Advanced panel starts to display a wrong "null" string.

emccorson
emccorson approved these changes Sep 8, 2024
View reviewed changes
Copy link
Collaborator

@emccorson emccorson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good! My only concern would be if an error gets thrown that isn't an instance of Error, it wouldn't be shown, but I'm not sure if that can ever happen.

@pedrorezende pedrorezende merged commit d9564f5 into main Sep 8, 2024
8 checks passed
@mateuszjasiuk mateuszjasiuk deleted the fix/namadillo/fixing-null-error-msg branch September 13, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emccorson emccorson emccorson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedrorezende @emccorson